Third concept of DNS batch. #787

mderka · 2016-03-24T23:47:46Z

The internals differ a bit, however, the interface is the same as in the second concept #777.

coveralls · 2016-03-25T01:30:04Z

Coverage decreased (-0.9%) to 84.666% when pulling 95318d8 on mderka:batch3 into c026e1a on GoogleCloudPlatform:dns-alpha-batch.

gcloud-java-core/src/main/java/com/google/gcloud/BatchResult.java

+package com.google.gcloud;
+
+/**
+ * The class that holds a single result of a batch call.


coveralls · 2016-04-04T21:38:43Z

Coverage decreased (-0.5%) to 85.11% when pulling 93102fe on mderka:batch3 into c026e1a on GoogleCloudPlatform:dns-alpha-batch.

mderka · 2016-04-04T21:38:59Z

I simplified the concept based on the suggestions of @aozarov. Please, take a look. If the concept seems ok, I will proceed and implement the tests, the rest of the operations etc. and create a proper PR.

gcloud-java-core/src/main/java/com/google/gcloud/BatchResult.java

+  /**
+   * Returns result of this call.
+   *
+   * @throws IllegalArgumentException if the batch has not been submitted yet


mderka · 2016-04-13T17:43:24Z

All done. This should be squashed before merging.

coveralls · 2016-04-13T17:46:54Z

Changes Unknown when pulling 1c60ba0 on mderka:batch3 into * on GoogleCloudPlatform:dns-alpha-batch*.

ajkannan · 2016-04-13T20:45:36Z

LGTM

gcloud-java-core/src/main/java/com/google/cloud/BatchResult.java

+ * This class holds a single result of a batch call. {@code T} is the type of the result and {@code
+ * E} is the type of the service-dependent exception thrown when a processing error occurs.
+ */
+public abstract class BatchResult<T, E extends BaseServiceException> {


@VisibleForTesting

* Added third concept of DNS batch. * Simplified the internals. Removed DnsBatch.Request. * Work in progress. Implemented more calls and added tests. * Turned BatchResult into an abstract class. * Created RpcBatch interface for opacity of batch. Added core unit test for BatchResult. Added javadoc for BatchResult generics. Changed prefix of newCallback methods. Fixed method javadoc. * Fixed documentation. * Removed addToBatch methods from RPC. * Removed conflicts with master branch. * Implemented batch processing for change requests and record sets. * Implemented the rest of the batch functions and tests. - Renames several forgotten DnsRecord variables and functions in tests - Moved the Callback interface from DnsRpc to RpcBatch * Added tests for callbacks. Fixed documentation. * Added onFailure callback tests and fixed one doc string. * Extracted GoogleJsonError to a final attribute. * Fixed imports and implemented notify. * Fixed import orders * Annotated getters as @VisibleForTesting. * Fixed docs and renamed a few methods. Also consolidated mocks batch in tests. * Added notify test * Renamed submitted() to completed(). * Consolidated more tests and added exception to notify. * Added test for null result in BatchResult.

…to v0.9.12 (#787) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.graalvm.buildtools:junit-platform-native](https://togithub.com/graalvm/native-build-tools) | `0.9.11` -> `0.9.12` | [![age](https://badges.renovateapi.com/packages/maven/org.graalvm.buildtools:junit-platform-native/0.9.12/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.graalvm.buildtools:junit-platform-native/0.9.12/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.graalvm.buildtools:junit-platform-native/0.9.12/compatibility-slim/0.9.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.graalvm.buildtools:junit-platform-native/0.9.12/confidence-slim/0.9.11)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>graalvm/native-build-tools</summary> ### [`v0.9.12`](https://togithub.com/graalvm/native-build-tools/releases/tag/0.9.12) [Compare Source](https://togithub.com/graalvm/native-build-tools/compare/0.9.11...0.9.12) ##### What's Changed Read what's new in the [documentation](https://graalvm.github.io/native-build-tools/latest/index.html#changelog). - Add Mockito / Byte Buddy support documentation by [@lazar-mitrovic](https://togithub.com/lazar-mitrovic) in [graalvm/native-build-tools#236 - Prevent builds from failing if no test list is present by [@lazar-mitrovic](https://togithub.com/lazar-mitrovic) in [graalvm/native-build-tools#239 - Support different agent modes in the native-image Gradle plugin by [@gradinac](https://togithub.com/gradinac) in [graalvm/native-build-tools#230 - JVM Reachability Metadata support for Maven by [@alvarosanchez](https://togithub.com/alvarosanchez) in [graalvm/native-build-tools#240 - Warn about deprecated agent DSL by [@gradinac](https://togithub.com/gradinac) in [graalvm/native-build-tools#242 - Rework Maven plugin by [@lazar-mitrovic](https://togithub.com/lazar-mitrovic) in [graalvm/native-build-tools#247 - Add Gradle rich output support, configure default metadata URL on Maven by [@lazar-mitrovic](https://togithub.com/lazar-mitrovic) in [graalvm/native-build-tools#249 - Fix wrong scope for test dependencies by [@melix](https://togithub.com/melix) in [graalvm/native-build-tools#251 - Add documentation for alternative build systems. by [@gradinac](https://togithub.com/gradinac) in [graalvm/native-build-tools#248 **Full Changelog**: graalvm/native-build-tools@0.9.11...0.9.12 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-secretmanager).

…a to 2.18.1 (googleapis#787) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 450543911 Source-Link: googleapis/googleapis@5528344 Source-Link: https://github.com/googleapis/googleapis-gen/commit/9f6775cab1958982b88967a43e5e806af0f135db Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWY2Nzc1Y2FiMTk1ODk4MmI4ODk2N2E0M2U1ZTgwNmFmMGYxMzVkYiJ9

🤖 I have created a release *beep* *boop* --- ## [2.3.0](googleapis/java-secretmanager@v2.2.0...v2.3.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#790](googleapis/java-secretmanager#790)) ([d41cd58](googleapis/java-secretmanager@d41cd58)) ### Documentation * **sample:** clean up README for native image sample ([googleapis#785](googleapis/java-secretmanager#785)) ([c6005b3](googleapis/java-secretmanager@c6005b3)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#789](googleapis/java-secretmanager#789)) ([6591df5](googleapis/java-secretmanager@6591df5)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.0 ([googleapis#779](googleapis/java-secretmanager#779)) ([ff31a24](googleapis/java-secretmanager@ff31a24)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.1 ([googleapis#780](googleapis/java-secretmanager#780)) ([9011c89](googleapis/java-secretmanager@9011c89)) * update dependency com.google.protobuf:protobuf-java-util to v3.21.2 ([googleapis#791](googleapis/java-secretmanager#791)) ([1fdde19](googleapis/java-secretmanager@1fdde19)) * update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([googleapis#787](googleapis/java-secretmanager#787)) ([b1bde96](googleapis/java-secretmanager@b1bde96)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([googleapis#788](googleapis/java-secretmanager#788)) ([9c10bdf](googleapis/java-secretmanager@9c10bdf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@7336562 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00

🤖 I have created a release *beep* *boop* --- ## [2.5.1](googleapis/java-recommender@v2.5.0...v2.5.1) (2022-07-13) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-recommender/issues/1485)) ([#787](googleapis/java-recommender#787)) ([4dac477](googleapis/java-recommender@4dac477)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.3.2](googleapis/java-scheduler@v2.3.1...v2.3.2) (2022-07-19) ### Bug Fixes * enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-scheduler/issues/1485)) ([#787](googleapis/java-scheduler#787)) ([6082618](googleapis/java-scheduler@6082618)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.4.3](googleapis/java-accessapproval@v2.4.2...v2.4.3) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#779](googleapis/java-accessapproval#779)) ([f11b5f4](googleapis/java-accessapproval@f11b5f4)) * update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#780](googleapis/java-accessapproval#780)) ([ccbc03d](googleapis/java-accessapproval@ccbc03d)) * update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#784](googleapis/java-accessapproval#784)) ([2b8872d](googleapis/java-accessapproval@2b8872d)) * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#785](googleapis/java-accessapproval#785)) ([464c702](googleapis/java-accessapproval@464c702)) * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#786](googleapis/java-accessapproval#786)) ([4d28115](googleapis/java-accessapproval@4d28115)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#781](googleapis/java-accessapproval#781)) ([f8fac7c](googleapis/java-accessapproval@f8fac7c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [3.5.3](googleapis/java-cloudbuild@v3.5.2...v3.5.3) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#787](googleapis/java-cloudbuild#787)) ([9c303ad](googleapis/java-cloudbuild@9c303ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 477955264 Source-Link: https://togithub.com/googleapis/googleapis/commit/a724450af76d0001f23602684c49cd6a4b3a5654 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.5.6](https://togithub.com/googleapis/java-bigqueryconnection/compare/v2.5.5...v2.5.6) (2022-10-05) ### Bug Fixes * update protobuf to v3.21.7 ([923e978](https://togithub.com/googleapis/java-bigqueryconnection/commit/923e978deaa8a7d0b23567c4c72e38e6ca677369)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…787)

🤖 I have created a release *beep* *boop* --- ## [2.6.0](googleapis/java-core@v2.5.11...v2.6.0) (2022-04-14) ### Features * **java:** remove GoogleJsonClentFeature and OpenCensusFeature after relocation ([#793](googleapis/java-core#793)) ([cafd489](googleapis/java-core@cafd489)) * **java:** remove Netty Native Image configuration after relocation to gax ([#771](googleapis/java-core#771)) ([9cc7dba](googleapis/java-core@9cc7dba)) * **java:** remove protobuf Native Image configuration ([#784](googleapis/java-core#784)) ([7a8df66](googleapis/java-core@7a8df66)) * remove native-image.properties settings after relocation ([#794](googleapis/java-core#794)) ([219a519](googleapis/java-core@219a519)) * remove resource-config after relocation ([#795](googleapis/java-core#795)) ([8ed3110](googleapis/java-core@8ed3110)) * remove substitutions after relocation to gax ([#789](googleapis/java-core#789)) ([85280b1](googleapis/java-core@85280b1)) ### Bug Fixes * **java:** register test class for reflection to fix native image test ([#766](googleapis/java-core#766)) ([fa07125](googleapis/java-core@fa07125)) ### Dependencies * revert protobuf to 3.19 and common-protos 2.8.3 ([#798](googleapis/java-core#798)) ([27ca70c](googleapis/java-core@27ca70c)) * update dependency com.google.api-client:google-api-client-bom to v1.34.0 ([#800](googleapis/java-core#800)) ([3abc47d](googleapis/java-core@3abc47d)) * update dependency com.google.api:gax-bom to v2.16.0 ([#785](googleapis/java-core#785)) ([bd33a76](googleapis/java-core@bd33a76)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.8.1 ([#792](googleapis/java-core#792)) ([3f85e62](googleapis/java-core@3f85e62)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.8.2 ([#796](googleapis/java-core#796)) ([d6ea18e](googleapis/java-core@d6ea18e)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.0 ([#783](googleapis/java-core#783)) ([48594f3](googleapis/java-core@48594f3)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.1 ([#799](googleapis/java-core#799)) ([9fe7d35](googleapis/java-core@9fe7d35)) * update dependency com.google.errorprone:error_prone_annotations to v2.12.1 ([#788](googleapis/java-core#788)) ([cfdabb4](googleapis/java-core@cfdabb4)) * update dependency com.google.http-client:google-http-client-bom to v1.41.6 ([#791](googleapis/java-core#791)) ([d9ff405](googleapis/java-core@d9ff405)) * update dependency com.google.http-client:google-http-client-bom to v1.41.7 ([#797](googleapis/java-core#797)) ([dfc3c57](googleapis/java-core@dfc3c57)) * update dependency com.google.protobuf:protobuf-bom to v3.20.0 ([#787](googleapis/java-core#787)) ([51f59fc](googleapis/java-core@51f59fc)) * update dependency io.grpc:grpc-bom to v1.45.1 ([#780](googleapis/java-core#780)) ([cd8a078](googleapis/java-core@cd8a078)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2016

mderka added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 24, 2016

mziccard reviewed Mar 25, 2016
View reviewed changes

gcloud-java-core/src/main/java/com/google/gcloud/BatchResult.java

package com.google.gcloud;

/**

* The class that holds a single result of a batch call.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

aozarov reviewed Apr 5, 2016
View reviewed changes

gcloud-java-core/src/main/java/com/google/gcloud/BatchResult.java

/**

* Returns result of this call.

*

* @throws IllegalArgumentException if the batch has not been submitted yet

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

ajkannan merged commit beea588 into googleapis:dns-alpha-batch Apr 13, 2016

aozarov reviewed Apr 13, 2016
View reviewed changes

mderka mentioned this pull request Apr 14, 2016

Disallowed null error in BatchResult. Adjusted doc. #921

Merged

mziccard mentioned this pull request Apr 20, 2016

Add support for batches to DNS #940

Merged

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency com.google.protobuf:protobuf-bom to v3.20.0 (#…

51f59fc

…787)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Third concept of DNS batch. #787

Third concept of DNS batch. #787

mderka commented Mar 24, 2016

coveralls commented Mar 25, 2016

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Apr 4, 2016

mderka commented Apr 4, 2016

This comment was marked as spam.

This comment was marked as spam.

mderka commented Apr 13, 2016

coveralls commented Apr 13, 2016

ajkannan commented Apr 13, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Third concept of DNS batch. #787

Third concept of DNS batch. #787

Conversation

mderka commented Mar 24, 2016

coveralls commented Mar 25, 2016

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Apr 4, 2016

mderka commented Apr 4, 2016

This comment was marked as spam.

This comment was marked as spam.

mderka commented Apr 13, 2016

coveralls commented Apr 13, 2016

ajkannan commented Apr 13, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.